Fix broken main: generated JS types #42422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jscheffl
requested review from
hussein-awala,
romsharon98,
eladkal and
shahar1
jscheffl
requested review from
bbovenzi,
pierrejeambrun and
ryanahamilton
as code owners
shahar1
approved these changes
Sep 23, 2024
vincbeck
approved these changes
Sep 23, 2024
|
Static checks green now... others still fail, therefore merging... |
|
Thanks, yes the change is intended, but I do not understand why this didn't break in my PR |
|
Hmmm this particular hook Edit: OK got it opening a PR. |
|
#42435 Hook wasn't re-wired on the new generated OpenAPI spec used by the front end, causing main failure. Thanks Jens shouldn't happen anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for static checks in https://github.com/apache/airflow/actions/runs/10995403123/job/30526485436
@pierrejeambrun was the API change intended that causes the generated DIFF? Or is this an unwanted side-effect?